Skip to content

Updated resource EndSilenceOutOfRange (#77598)#77599

Merged
jeffhandley merged 1 commit intodotnet:mainfrom
ChrisSippel:issue-77598
Oct 28, 2022
Merged

Updated resource EndSilenceOutOfRange (#77598)#77599
jeffhandley merged 1 commit intodotnet:mainfrom
ChrisSippel:issue-77598

Conversation

@ChrisSippel
Copy link

The resource EndSilenceOutOfRange was out of date

Fix #77598

The resource EndSilenceOutOfRange was out of date

Fix dotnet#77598
@ghost ghost added area-System.Speech community-contribution Indicates that the PR has been added by a community member labels Oct 28, 2022
@ghost
Copy link

ghost commented Oct 28, 2022

Tagging subscribers to this area: @ericstj, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Issue Details

The resource EndSilenceOutOfRange was out of date

Fix #77598

Author: ChrisSippel
Assignees: -
Labels:

area-System.Speech

Milestone: -

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@danmoseley
Copy link
Member

BTW, looks like there might be some dead strings to remove. Eg., RejectionThresholdOutOfRange. I thought I checked them all when I did the port.
I also happened to notice that SapiErrorTooManyGrammars says 1024 but the code says 2^64. Probably nobody ever gets this message so it's not important.

@jeffhandley jeffhandley merged commit 76cd5cb into dotnet:main Oct 28, 2022
@danmoseley
Copy link
Member

Thanks for spotting and fixing @ChrisSippel . Perhaps you feel like following up to remove any dead resources as noted above.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Speech community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EndSilenceTimeout and EndSilenceTimeoutAmbiguous for SpeechRecognitionEngine is 10 seconds instead of 100 seconds

4 participants