Use char.IsAsciiLetter in the Regex runtime#77559
Merged
stephentoub merged 2 commits intodotnet:mainfrom Oct 28, 2022
Merged
Conversation
Need to move the duplicated IsAsciiLetter method to just the source generator, since the source generator can't reference the char API. That way the runtime doesn't need to pay for a duplicated method.
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsNeed to move the duplicated IsAsciiLetter method to just the source generator, since the source generator can't reference the char API. That way the runtime doesn't need to pay for a duplicated method.
|
stephentoub
approved these changes
Oct 27, 2022
Member
stephentoub
left a comment
There was a problem hiding this comment.
LGTM. You could also put the helper in the Stubs.cs file that's next to this one; that's where we've put other polyfills and such things for use in the generator.
Move helepr method to Stubs.cs.
joperezr
approved these changes
Oct 27, 2022
This was referenced Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to move the duplicated IsAsciiLetter method to just the source generator, since the source generator can't reference the char API. That way the runtime doesn't need to pay for a duplicated method.