Skip to content

Conversation

@AaronRobinsonMSFT
Copy link
Member

The compiles and runs without palrt.
The memcpy in the PAL was a thin wrapper and
didn't appear to add any additional value. The
PAL export was removed and the memcpy macro
was removed in most cases.

The compiles and runs without palrt.
The memcpy in the PAL was a thin wrapper and
didn't appear to add any additional value. The
PAL export was removed and the memcpy macro
was removed in most cases.
@build-analysis build-analysis bot mentioned this pull request Oct 27, 2022
2 tasks
@AaronRobinsonMSFT
Copy link
Member Author

Failure is dotnet/arcade#11447

@oleksandr-didyk
Copy link
Contributor

oleksandr-didyk commented Oct 31, 2022

/azp run runtime-coreclr superpmi-replay

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AaronRobinsonMSFT
Copy link
Member Author

@janvorli Can you take another look?

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 15f8cd9 into dotnet:main Nov 4, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the remove_some_pal_uses branch November 4, 2022 14:22
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants