-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Remove palrt from JIT and remove memcpy from PAL
#77556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AaronRobinsonMSFT
merged 3 commits into
dotnet:main
from
AaronRobinsonMSFT:remove_some_pal_uses
Nov 4, 2022
Merged
Remove palrt from JIT and remove memcpy from PAL
#77556
AaronRobinsonMSFT
merged 3 commits into
dotnet:main
from
AaronRobinsonMSFT:remove_some_pal_uses
Nov 4, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiles and runs without palrt. The memcpy in the PAL was a thin wrapper and didn't appear to add any additional value. The PAL export was removed and the memcpy macro was removed in most cases.
janvorli
reviewed
Oct 27, 2022
2 tasks
janvorli
reviewed
Oct 27, 2022
2 tasks
Member
Author
|
Failure is dotnet/arcade#11447 |
Contributor
|
/azp run runtime-coreclr superpmi-replay |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@janvorli Can you take another look? |
janvorli
approved these changes
Nov 4, 2022
Member
janvorli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiles and runs without
palrt.The
memcpyin the PAL was a thin wrapper anddidn't appear to add any additional value. The
PAL export was removed and the
memcpymacrowas removed in most cases.