[mono][interp] Small improvements to get span item#77331
Merged
BrzVlad merged 3 commits intodotnet:mainfrom Oct 23, 2022
Merged
[mono][interp] Small improvements to get span item#77331BrzVlad merged 3 commits intodotnet:mainfrom
BrzVlad merged 3 commits intodotnet:mainfrom
Conversation
Field offsets are known at compile time, they don't need to be included in the code stream.
|
Tagging subscribers to this area: @BrzVlad Issue DetailsSimplify opcode and avoid typical use of ldloca with it.
|
vargaz
approved these changes
Oct 22, 2022
vargaz
reviewed
Oct 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify opcode and avoid typical use of ldloca with it.