Skip to content

Update .vsconfig file#77189

Merged
jeffhandley merged 3 commits intodotnet:mainfrom
jeffhandley:jeffhandley/vsconfig
Oct 20, 2022
Merged

Update .vsconfig file#77189
jeffhandley merged 3 commits intodotnet:mainfrom
jeffhandley:jeffhandley/vsconfig

Conversation

@jeffhandley
Copy link
Member

@jeffhandley jeffhandley commented Oct 18, 2022

While setting up a new machine, I tried using the .vsconfig file to configure Visual Studio 2022 Community, but I encountered a few problems:

  1. I received an error about the 4.5.2 targeting pack
    • The docs cited this possibility but mention it's OK as long as there's a newer targeting pack
    • Since this config includes newer targeting packs, I went ahead and removed 4.5.2 and removed the blurb from the docs
  2. I added Python and CMake, which were both missing but needed to perform a build
  3. I bumped the Runtime from 5.0 to 6.0
  4. I added the Roslyn SDK for source generator/analyzer work

I also sorted the lines in the file to make it easier to scan/review, but I did that as a separate commit for reviewing the changes (346eb14) vs. the sorting (2480483) in this PR.

With this updated config file, I can cleanly build clr+libs+libs.tests with a fresh install of VS 2022 Community, importing these settings only.

@jeffhandley jeffhandley added documentation Documentation bug or enhancement, does not impact product or test code area-Meta labels Oct 18, 2022
@jeffhandley jeffhandley added this to the 8.0.0 milestone Oct 18, 2022
@ghost
Copy link

ghost commented Oct 18, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

While setting up a new machine, I tried using the .vsconfig file to configure Visual Studio 2022 Community, but I encountered a few problems:

  1. I received an error about the 4.5.2 targeting pack
    • The docs cited this possibility but mention it's OK as long as there's a newer targeting pack
    • Since this config includes newer targeting packs, I went ahead and removed 4.5.2 and removed the blurb from the docs
  2. I added Python and CMake, which were both missing but needed to perform a build
  3. I bumped the Runtime from 5.0 to 6.0
  4. I added the Roslyn SDK for source generator/analyzer work

I also sorted the lines in the file to make it easier to scan/review, but I did that as a separate commit for reviewing the changes (346eb14) vs. the sorting (2480483) in this PR.

With this updated config file, I can cleanly build clr+libs+libs.tests with a fresh install of VS 2022 Community, importing these settings only.

Author: jeffhandley
Assignees: -
Labels:

documentation, area-Meta
Milestone: 8.0.0

@ghost ghost assigned jeffhandley Oct 18, 2022
@build-analysis build-analysis bot mentioned this pull request Oct 19, 2022
Closed
hoyosjs
hoyosjs reviewed Oct 19, 2022
View reviewed changes
@AntonLapounov
Copy link
Member

AntonLapounov commented Oct 19, 2022

It wasn't easy to see the real diff due to different ordering:

-    "Microsoft.Net.Component.4.5.2.TargetingPack",
-    "Microsoft.NetCore.Component.Runtime.5.0",
+    "Component.CPython39.x64",
+    "Microsoft.Component.CodeAnalysis.SDK",
+    "Microsoft.NetCore.Component.Runtime.6.0",
+    "Microsoft.VisualStudio.Component.VC.CMake.Project",

AntonLapounov
AntonLapounov approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@AntonLapounov AntonLapounov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeffhandley
Copy link
Member Author

jeffhandley commented Oct 20, 2022

I also sorted the lines in the file to make it easier to scan/review, but I did that as a separate commit for reviewing the changes (346eb14) vs. the sorting (2480483) in this PR.

Thanks. Sorry about the ordering. It'll help in the future, but it made this one frustrating. Good tip on posting a comment with the actual diff, @AntonLapounov. :)

@jeffhandley
Copy link
Member Author

jeffhandley commented Oct 20, 2022

The failure was a timeout in a NativeAOT smoke test; unrelated.

Running Test: B282745.testMDArrayWith3Dimensions

cmdLine:D:\a\_work\1\s\artifacts\tests\coreclr\windows.x64.Checked\nativeaot\SmokeTests\DynamicGenerics\DynamicGenerics\DynamicGenerics.cmd Timed Out (timeout in milliseconds: 1800000 from variable __TestTimeout, start: 10/20/2022 2:49:58 AM, end: 10/20/2022 3:19:58 AM)

@jeffhandley jeffhandley merged commit fce9117 into dotnet:main Oct 20, 2022
@jeffhandley jeffhandley deleted the jeffhandley/vsconfig branch October 20, 2022 17:09
@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hoyosjs hoyosjs hoyosjs left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@AntonLapounov AntonLapounov AntonLapounov approved these changes

Assignees

@jeffhandley jeffhandley

Labels

area-Meta documentation Documentation bug or enhancement, does not impact product or test code

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jeffhandley @AntonLapounov @ViktorHofer @hoyosjs