Skip to content

[wasm] Fix support for debugging wasm debugger tests with VSCode#77148

Merged
lewing merged 8 commits intodotnet:mainfrom
radical:wasm-debugger-tests-debug
Oct 28, 2022
Merged

[wasm] Fix support for debugging wasm debugger tests with VSCode#77148
lewing merged 8 commits intodotnet:mainfrom
radical:wasm-debugger-tests-debug

Conversation

@radical
Copy link
Member

@radical radical commented Oct 18, 2022 •
edited
Loading

Screen Shot 2022-10-17 at 11 10 06 PM

@radical radical requested a review from thaystg as a code owner October 18, 2022 03:00
@ghost ghost added the area-Debugger-mono label Oct 18, 2022
@ghost ghost assigned radical Oct 18, 2022
@ghost
Copy link

ghost commented Oct 18, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

area-Debugger-mono
Milestone: -

@radical radical requested review from ilonatommy and lewing October 18, 2022 03:01
@radical radical added the arch-wasm WebAssembly architecture label Oct 18, 2022
@ghost
Copy link

ghost commented Oct 18, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@radical radical added this to the 8.0.0 milestone Oct 18, 2022
@radical
Copy link
Member Author

radical commented Oct 18, 2022

@thaystg @ilonatommy I haven't tried this on windows, could you please do that?

@ilonatommy
Copy link
Member

ilonatommy commented Oct 18, 2022 •
edited
Loading

So far I checked running the tests from Poweshell and it has changed. After setting the RunSettingsFilePath dotnet.sh/cmd is expected to reside in one of the paths specified in DebuggerTestSuite.csproj, e.g. \artifacts\obj\vscode\. Thus, running

./dotnet.cmd test src/mono/wasm/debugger/DebuggerTestSuite --filter DebuggerTests.EvaluateOnCallFrameTests.EvaluateStaticLocalsWithDeepMemberAccess -e RuntimeConfiguration=Debug -e Configuration=Debug -e DebuggerHost=chrome > out.txt

that worked before does not work anymore, from the vscode dir in artifacts either:
./../../../dotnet.cmd test ../../../src/mono/wasm/debugger/DebuggerTestSuite ....etc

Failed to launch testhost with error: System.IO.FileNotFoundException: Path does not exist: runtime-fork\artifacts\obj\vscode\dotnet.exe
File name: 'runtime-fork\artifacts\obj\vscode\dotnet.exe'
   at Microsoft.VisualStudio.TestPlatform.PlatformAbstractions.ProcessHelper.LaunchProcess(String processPath, String arguments, String workingDirectory, IDictionary`2 envVariables, Action`2 errorCallback, Action`1 exitCallBack, Action`2 outputCallBack)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting.DotnetTestHostManager.LaunchHost(TestProcessStartInfo testHostStartInfo, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting.DotnetTestHostManager.LaunchTestHostAsync(TestProcessStartInfo testHostStartInfo, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable`1 sources, String runSettings)

I cannot come with a workaround, it might be something simple but what about adding some info here if any additional steps are needed now, to avoid confusion?

@radical
Copy link
Member Author

radical commented Oct 18, 2022

I will fix invoking it from the shell. Are you able to run a test by "run test" or "debug test" shown over a test?

@radical
Copy link
Member Author

radical commented Oct 18, 2022

I meant this:
Screen Shot 2022-10-18 at 4 33 58 PM

@radical radical requested a review from pavelsavara as a code owner October 18, 2022 23:53
@lewing lewing merged commit cc5ba09 into dotnet:main Oct 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@thaystg thaystg thaystg approved these changes

@ilonatommy ilonatommy Awaiting requested review from ilonatommy

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Debugger-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@radical @ilonatommy @lewing @thaystg