Filter out addresses that are not in bookkeeping range during background promote#77067
Merged
cshung merged 4 commits intodotnet:mainfrom Oct 21, 2022
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
jkotas
reviewed
Oct 15, 2022
Member
|
Is this fixing any known bug or crash? |
Contributor
Author
It fixed a crash if we set I was attempting to use CoreCLR to figure out what might have gone wrong with the NativeAOT CI failure. We have found something, but not the one that is causing the CI failure. |
jkotas
reviewed
Oct 15, 2022
jkotas
reviewed
Oct 15, 2022
jkotas
reviewed
Oct 15, 2022
Maoni0
approved these changes
Oct 20, 2022
Member
Maoni0
left a comment
There was a problem hiding this comment.
other than the slight refactoring we talked about, the rest LGTM
85e358d to
d72e781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.