NativeAOT: remove some headers that are not needed#77042
Merged
jkotas merged 2 commits intodotnet:mainfrom Oct 17, 2022
Merged
Conversation
am11
reviewed
Oct 14, 2022
|
|
||
| check_include_files(sys/vmparam.h HAVE_SYS_VMPARAM_H) | ||
| check_include_files(mach/vm_types.h HAVE_MACH_VM_TYPES_H) | ||
| check_include_files(mach/vm_param.h HAVE_MACH_VM_PARAM_H) |
Member
There was a problem hiding this comment.
HAVE_PTHREAD_ATTR_GET_NP and HAVE_UCONTEXT_T are also unused.
Member
Author
There was a problem hiding this comment.
HAVE_PTHREAD_ATTR_GET_NP is used here https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp#L1116
I don't actually see where HAVE_UCONTEXT_T is being defined, but it is set to 1 somehow.
Member
There was a problem hiding this comment.
HAVE_UCONTEXT_T is in config.h.in and check_type_size(ucontext_t UCONTEXT_T) in this file, which can be deleted.
Yes, HAVE_PTHREAD_ATTR_GET_NP is in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small cleanup.