Trim trailing SP and HTAB for header value on HTTP/1.1#77030
Merged
MihaZupan merged 4 commits intodotnet:mainfrom Nov 1, 2022
Merged
Trim trailing SP and HTAB for header value on HTTP/1.1#77030MihaZupan merged 4 commits intodotnet:mainfrom
MihaZupan merged 4 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsTrim trailing SP and HTAB for header value on HTTP/1.1 Fixes #77001 Please review
|
2 tasks
Member
|
Thanks @Marusyk for your PR! That was fast :) |
MihaZupan
reviewed
Oct 14, 2022
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnection.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
2 tasks
Member
Author
Member
|
I would make this a runtime/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs Lines 3683 to 3684 in 960e4d7 |
MihaZupan
approved these changes
Oct 17, 2022
src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
Outdated
Show resolved
Hide resolved
…pHandlerTest.cs Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trim trailing SP and HTAB for header value on HTTP/1.1
Fixes #77001
Please review
Thank you in advance