Merged
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsThis change enables The reason why The commits are intentionally bypassing the hard limit check.
|
63d1f8f to
2fc34bc
Compare
Maoni0
approved these changes
Oct 20, 2022
Member
Maoni0
left a comment
There was a problem hiding this comment.
other than what we talked about about moving where we are calling initGCShadow, it LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables
HEAPVERIFY=2for regions.The reason why
HEAPVERIFY=2didn't work for regions is that we were trying tovirtual_committhe full reserved range, but it usually won't work underUSE_REGIONSbecause by default it is 256G large. Instead, the change reserves the full reserved range, and then incrementally commits as the heap grows.The commits are intentionally bypassing the hard limit check.