Fix loop canonicalization for call-finally case#76734
Merged
BruceForstall merged 2 commits intodotnet:mainfrom Oct 11, 2022
Merged
Fix loop canonicalization for call-finally case#76734BruceForstall merged 2 commits intodotnet:mainfrom
BruceForstall merged 2 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
I saw no asm diffs locally. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIf a call-finally is followed by a loop body that requires canonicalization, we hit an assert that the To fix this, add a new canonicalization. If this case occurs, simply insert a new fall-through block above the loop top and redirect the BBJ_ALWAYS to that new block. Fixes #76346
|
Contributor
Author
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
@AndyAyersMS @dotnet/jit-contrib PTAL |
AndyAyersMS
approved these changes
Oct 7, 2022
If a call-finally is followed by a loop body that requires canonicalization, we hit an assert that the `head` block preceding the loop must be a fall-through block. This was true in all cases except if the preceding block was the BBJ_ALWAYS of a BBJ_CALLFINALLY/BBJ_ALWAYS pair. To fix this, add a new canonicalization. If this case occurs, simply insert a new fall-through block above the loop top and redirect the BBJ_ALWAYS to that new block. Fixes dotnet#76346
744943e to
9e8fabc
Compare
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a call-finally is followed by a loop body that requires canonicalization, we hit an assert that the
headblock preceding the loop must be a fall-through block. This was true in all cases except if the preceding block was the BBJ_ALWAYS of a BBJ_CALLFINALLY/BBJ_ALWAYS pair.To fix this, add a new canonicalization. If this case occurs, simply insert a new fall-through block above the loop top and redirect the BBJ_ALWAYS to that new block.
Fixes #76346