Skip to content

Remove GUID <=> string functions in PAL#76729

Merged
AaronRobinsonMSFT merged 4 commits intodotnet:mainfrom
AaronRobinsonMSFT:remove_guid_to_string_funcs
Oct 7, 2022
Merged

Remove GUID <=> string functions in PAL#76729
AaronRobinsonMSFT merged 4 commits intodotnet:mainfrom
AaronRobinsonMSFT:remove_guid_to_string_funcs

Conversation

@AaronRobinsonMSFT
Copy link
Member

This replaces and removes all uses of IIDFromString
and StringFromGUID2. These are Win32 functions
that are oddly named and cumbersome to use. The
PAL versions are also removed.

These are now replaced with consistent replacements.

  • LPCWSTRToGuid
  • GuidToLPWSTR
  • LPCSTRToGuid
  • GuidToLPSTR

@AaronRobinsonMSFT
Copy link
Member Author

/cc @janvorli - Continuing to remove PAL APIs!

@AaronRobinsonMSFT AaronRobinsonMSFT changed the title Remove GUID to string functions in PAL Remove GUID <=> string functions in PAL Oct 6, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review October 7, 2022 04:19
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 3e600c9 into dotnet:main Oct 7, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the remove_guid_to_string_funcs branch October 7, 2022 17:31
@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants