Make sure isRunSmokeTestsOnly is false when manually triggering runtime-extra-platforms#76715
Conversation
…me-extra-platforms Also, remove runtime-bionic references in the yml as this pipeline does not exist.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can we take 9ca3960 into this PR instead? edit: there was a typo, updated to up to date link |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| value: ${{ notin(variables['Build.DefinitionName'], 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-ioslike', 'runtime-ioslikesimulator', 'runtime-android', 'runtime-androidemulator', 'runtime-maccatalyst', 'runtime-linuxbionic') }} | ||
|
|
||
| # We only run evaluate paths on runtime, runtime-staging and runtime-community pipelines on PRs | ||
| # keep in sync with /eng/pipelines/common/xplat-setup.yml |
There was a problem hiding this comment.
looks like we didn't keep this in sync :)
There was a problem hiding this comment.
though now that I think about it, not sure it makes sense to have them depend on evaluatepaths since they should always trigger I guess?
There was a problem hiding this comment.
I think so. If we want to restrict it we can always add later.
There was a problem hiding this comment.
I only looked at a few commits in the past when only adding runtime-extra-platforms to the isRunSmokeTestsOnly section, it looks like the two diverged in #64830
Also, remove runtime-bionic references in the yml as this pipeline does not exist.