Add specific formatting string for SSA numbers#76706
Add specific formatting string for SSA numbers#76706BruceForstall wants to merge 2 commits intodotnet:mainfrom
Conversation
Format all SSA numbers with the new `FMT_SSA` string. Currently, this is defined as `ssa%u`, which makes it easy to identify a string as an SSA number, as well as making it easy to search for this string throughout the JitDump.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFormat all SSA numbers with the new Currently, this is defined as Examples:
|
|
@AndyAyersMS @dotnet/jit-contrib PTAL |
|
I kind of like the current
|
May be |
|
I'm very biased towards something that is context-free searchable. My peculiar preference is something that works with vi's default settings for the '*' and '#' search commands. |
Yep, and that's why I was suggesting to append with |
SSA no longer relevant once we get to LSRA, so it seems like this wouldn't be too much of a problem? Or we could use some other single char that we don't use when dumping flags, like |
|
It looks like we don't use
@AndyAyersMS Maybe you can describe more specifically what you don't like about We have some similar examples: statements: "STMT%05d", nodes: "N%03d", CSE: "CSE #%02u" (I'd prefer "cse%02u"). Even using "S%u" might be unique enough, but certainly isn't as obvious to the newcomer (to the JIT or phase). |
The ssa number on its own is not very interesting. We should always display it as a suffix of the var, eg |
|
I'm going to close this for now. |
Format all SSA numbers with the new
FMT_SSAstring.Currently, this is defined as
ssa%u, which makes it easy to identify a string as an SSA number, as well as making it easy to search for this string throughout the JitDump.Examples: