JIT: disable phi based redundant branch opts#76695
Merged
BruceForstall merged 1 commit intodotnet:mainfrom Oct 6, 2022
Merged
Conversation
This is exposing our lack of SSA update and leading downstream opts like CSE and assertion prop to make bad decisions. Disabling for now until I have time to figure out how to safely enable. Fixes dotnet#76636, dotnet#76507
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis is exposing our lack of SSA update and leading downstream opts like CSE and assertion prop to make bad decisions. Disabling for now until I have time to figure out how to safely enable.
|
Member
Author
|
@BruceForstall PTAL See linked issues for some analysis on what goes wrong. |
EgorBo
approved these changes
Oct 6, 2022
Member
Author
|
Runtime test failures look spurious. |
Member
Author
|
/azp run runtime-coreclr libraries-jitstress, runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
BruceForstall
approved these changes
Oct 6, 2022
Contributor
|
Only jitstress failure looks like an existing System.Net.Sockets issue #72365 |
This was referenced Oct 6, 2022
This was referenced Oct 11, 2022
This was referenced Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is exposing our lack of SSA update and leading downstream opts like CSE and assertion prop to make bad decisions.
Disabling for now until I have time to figure out how to safely enable.
Fixes #76636, #76507
Diffs show lots of code size increases. Hopefully we can get most of this back.