Fix using DependencyGraphViewer with AOT compilers#76357
Merged
jkotas merged 1 commit intodotnet:mainfrom Sep 29, 2022
Merged
Conversation
The `readonly` addition was one of the 3600 diffs in dotnet#74825. `MarkStrategy` can have mutable state that was getting lost because Roslyn considers it valid to put `_marker` into a temporary before calling instance methods on it. This resulted in DependencyGraphViewer hanging after seeing tens of thousands of new graphs being added.
jkotas
approved these changes
Sep 29, 2022
2 tasks
Member
|
Opened dotnet/arcade#11056 on the infrastructure failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
readonlywas added in #74825.MarkStrategycan have mutable state that was getting lost because Roslyn considers it necessary to put_markerinto a temporary before calling instance methods on it.This resulted in DependencyGraphViewer hanging after seeing tens of thousands of new graphs being added.
Cc @dotnet/ilc-contrib