Revert changes to EncoderNLS/DecoderNLS.Convert#752
Merged
jkotas merged 1 commit intodotnet:masterfrom Dec 27, 2019
Merged
Conversation
Member
Author
|
I was seeing some unexpected System.Private.Xml test failures on my machine, but I don't think the failing tests were related to this code change. Giving CI a shot to see if things pass there. |
krwq
approved these changes
Dec 11, 2019
Member
Author
|
Temporarily marking as no merge because it's dependent on #494 (live-local builds). Once that goes through, this can go through. |
stephentoub
approved these changes
Dec 11, 2019
Member
|
/azp run runtime-libraries |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #594.
This restores the original completed output parameter behavior that was present in Full Framework and .NET Core 2.x, reverting the changes that were introduced in the .NET Core 3.0 / 3.1 timeframe. I've also added a code comment explaining the contract of the completed parameter for the
Convertroutines. That comment can serve as the basis for updated API documentation text.This PR is for .NET 5.0 specifically. After approval there will be separate PRs for .NET Core 3.1.1 (downlevel).