Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThe old docs used a wrong type, probably a leftover from being copied over. For the webpage docs, see dotnet/dotnet-api-docs#8340
|
danmoseley
approved these changes
Aug 28, 2022
stephentoub
reviewed
Sep 6, 2022
| /// <typeparam name="TTo">The type of the vector <paramref name="vector" /> should be reinterpreted as.</typeparam> | ||
| /// <param name="vector">The vector to reinterpret.</param> | ||
| /// <returns><paramref name="vector" /> reinterpreted as a new <see cref="Vector64{U}" />.</returns> | ||
| /// <returns><paramref name="vector" /> reinterpreted as a new <see cref="Vector{U}" />.</returns> |
Member
Contributor
There was a problem hiding this comment.
I see that the type param name used in a see cref doesn't actually affect how it's displayed in docs.microsoft.com - so perhaps the only reason to update it is when reading the source code.
adamsitnik
approved these changes
Oct 10, 2022
Member
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @MichalPetryka !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old docs used a wrong type, probably a leftover from being copied over.
For the webpage docs, see dotnet/dotnet-api-docs#8340