JIT: finish converting all phases to use common post phase dumps and checks#74308
Merged
AndyAyersMS merged 15 commits intodotnet:mainfrom Aug 23, 2022
Merged
JIT: finish converting all phases to use common post phase dumps and checks#74308AndyAyersMS merged 15 commits intodotnet:mainfrom
AndyAyersMS merged 15 commits intodotnet:mainfrom
Conversation
This has a few small diffs, as I had to disable jump threading in one case and generalize how morph updates the loop table.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsConvert the remaining phases to common checks. Update the loop removal detection in morph to spot the case where we remove a head->entry edge. Fix RBO to not jump thread through a block that is a loop head (leads to small number of diffs). Remove the various whitelists now that all phases are using the common checks and dumps. Suppress dumps once we get to codegen as they're less relevant. Note: sub phases don't participate -- I am tempted to just remove them entirely. Contributes to #2109.
|
Member
Author
|
@dotnet/jit-contrib PTAL |
12 tasks
Member
Author
|
SPMI failure is known issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the remaining phases to common checks.
Update the loop removal detection in morph to spot the case where we remove a head->entry edge. Fix RBO to not jump thread through a block that is a loop head (leads to small number of diffs).
Remove the various whitelists now that all phases are using the common checks and dumps. Suppress dumps once we get to codegen as they're less relevant.
Note: sub phases don't participate -- I am tempted to just remove them entirely.
Contributes to #2109.