fix for SIP regions #74298
fix for SIP regions #74298
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue Detailswe should not be attributing the survived from SIP to fixes #74286
|
|
Is this something that we want to consider for RC1? If so, we need to merge in main and start the backport to RC1 before EOD PT. |
|
SIP for regions is disabled in rc1, but we should take for 7 for rc2. @Maoni0 ? |
|
yeah, rc2 is fine. is there any special process for rc2? |
|
@Maoni0 I'm genuinely curious that no testing is added when fixing this sort of thing. Is it always that way? Thanks :) |
|
there will be testing added for this specific thing, ie, SIP in WKS GC with no concurrent (WKS GC with no concurrent is definitely the config that gets the least amount of perf testing). this is a trivial fix and we are in the middle of changing our perf infra so we haven't added the testing specifically for it yet. |
we should not be attributing the survived from SIP to
generation_allocation_sizeif it's in the same generation. the effect of this is very obvious when we are doing a lot of gen2 blocking GCs.fixes #74286