Skip to content

Copy the string instead of returning different pointers #73795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cshung merged 1 commit into from
Aug 14, 2022
Merged

Copy the string instead of returning different pointers #73795

cshung merged 1 commit into from
Aug 14, 2022

Conversation

@cshung
Copy link
Contributor

@cshung cshung commented Aug 11, 2022

No description provided.

@cshung cshung added this to the 7.0.0 milestone Aug 11, 2022
@cshung cshung requested a review from noahfalk August 11, 2022 17:37
@cshung cshung self-assigned this Aug 11, 2022
@ghost
Copy link

ghost commented Aug 11, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr
Milestone: 7.0.0

@cshung cshung force-pushed the public/copy-string branch from 3e02329 to b8f90ca Compare August 11, 2022 18:02
noahfalk
noahfalk approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : )

@cshung cshung force-pushed the public/copy-string branch from b8f90ca to ebabc49 Compare August 14, 2022 04:28
@cshung cshung merged commit 1d8cccc into dotnet:main Aug 14, 2022
@cshung cshung deleted the public/copy-string branch August 14, 2022 07:08
@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalk noahfalk noahfalk approved these changes

Assignees

@cshung cshung

Labels

area-GC-coreclr

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@cshung @noahfalk