Skip to content

Mark RunGetBitLengthTestsLarge as outerloop and skipped on iOS/tvOS/Android/Browser #73773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 3 commits into from
Aug 12, 2022
Merged

Mark RunGetBitLengthTestsLarge as outerloop and skipped on iOS/tvOS/Android/Browser #73773

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04ff53b
Mark RunGetBitLengthTestsLarge as outerloop and skipped on unix platf…
tannergooding Aug 11, 2022
7caef97
Fix casing on OuterLoop
tannergooding Aug 11, 2022
285c12b
Changing the testplatforms filter to be more exact
tannergooding Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Runtime.Numerics/tests/BigInteger/GetBitLengthTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ public static void RunGetBitLengthTests()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.Is64BitProcess))] // OOM on 32 bit
[SkipOnPlatform(TestPlatforms.Browser, "OOM on browser due to large array allocations")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37093", TestPlatforms.Android)]
[OuterLoop("Allocates large arrays")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.Android | TestPlatforms.Browser, "OOM on browser and mobile due to large array allocations")]
public static void RunGetBitLengthTestsLarge()
{
// Very large cases
Expand Down