Skip to content

Conversation

@N0D4N
Copy link
Contributor

@N0D4N N0D4N commented Aug 11, 2022

Summary

Closes #73682
Repoint urls in docs and xmldocs from those that point to archived repos as dotnet/corefx, dotnet/coreclr, dotnet/core-setup so that they point to runtime repo. I also changed urls that point to file in dotnet/diagnostics repo that were moved, and urls that use obsolete default branch name.
In cases when commit hashes were used as part of url I used most recent commit hash.

Notes

@ghost ghost added area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member labels Aug 11, 2022
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Not sure about the failures. I pushed a minor fix to re run everything.

@danmoseley
Copy link
Member

Your notes above also seem reasonable. cc @MichalStrehovsky for the AOT links you mention.

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your notes above also seem reasonable. cc @MichalStrehovsky for the AOT links you mention.

The AOT stuff looks good. The links to deleted code are links to the deleted crossgen1. Crossgen2 devs liked referring to crossgen1 source code in comments. Those comments are only meaningful to those who know what crossgen1 was.

@danmoseley danmoseley merged commit 126045c into dotnet:main Aug 15, 2022
@danmoseley
Copy link
Member

Thanks @N0D4N

@N0D4N N0D4N deleted the repoint-urls branch August 15, 2022 06:09
@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repoint URL's to docs from corefx to runtime repo

3 participants