-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Repoint urls in docs #73766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repoint urls in docs #73766
Conversation
danmoseley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Not sure about the failures. I pushed a minor fix to re run everything.
|
Your notes above also seem reasonable. cc @MichalStrehovsky for the AOT links you mention. |
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your notes above also seem reasonable. cc @MichalStrehovsky for the AOT links you mention.
The AOT stuff looks good. The links to deleted code are links to the deleted crossgen1. Crossgen2 devs liked referring to crossgen1 source code in comments. Those comments are only meaningful to those who know what crossgen1 was.
|
Thanks @N0D4N |
Summary
Closes #73682
Repoint urls in docs and xmldocs from those that point to archived repos as dotnet/corefx, dotnet/coreclr, dotnet/core-setup so that they point to runtime repo. I also changed urls that point to file in dotnet/diagnostics repo that were moved, and urls that use obsolete default branch name.
In cases when commit hashes were used as part of url I used most recent commit hash.
Notes
I've left links in FreeBSD building instructions in place since patching them requires some knowledge about building coreclr and corefx that I don't have.
I also didn't change docs that point to corefxlab repo, even though it's archived I couldn't find those docs in dotnet/runtime and dotnet/designs repos
runtime/docs/coding-guidelines/api-guidelines/System.Memory.md
Lines 7 to 8 in 384dceb
Also i didn't repoint urls to PRs since it looks like they didn't move to dotnet/runtime
Also it seems there are some tests that use "obsolete" issue id as part of their filename like this one, i ignored such files.
https://github.com/dotnet/coreclr/blob/master/src/zap/ referenced in
runtime/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Line 1391 in 17154bd
runtime/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunMethod.cs
Line 552 in 17154bd
runtime/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/Amd64/UnwindInfo.cs
Line 173 in 753d12f
runtime/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/NativeReader.cs
Line 296 in 753d12f
runtime/src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/Ecma335/SignatureDecoder.cs
Line 315 in b908ecf
runtime/docs/project/garbage-collector-guidelines.md
Line 42 in 14be2a0