Skip to content

Use SSL_ctrl instead of SSL_CTX_ctrl to enable client OCSP stapling #73627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bartonjs merged 2 commits into from
Aug 10, 2022
Merged

Use SSL_ctrl instead of SSL_CTX_ctrl to enable client OCSP stapling #73627

bartonjs merged 2 commits into from
Aug 10, 2022

Conversation

@bartonjs
Copy link
Member

@bartonjs bartonjs commented Aug 9, 2022

This is required on OpenSSL 1.0.x, which is still in use on RHEL7 and CentOS7.

Fixes #71037

@bartonjs
Use SSL_ctrl instead of SSL_CTX_ctrl to enable client OCSP stapling
fedb907 
This is required on OpenSSL 1.0.x, which is still in use on RHEL7 and CentOS7
@bartonjs bartonjs added this to the 7.0.0 milestone Aug 9, 2022
@bartonjs bartonjs self-assigned this Aug 9, 2022
@ghost
Copy link

ghost commented Aug 9, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This is required on OpenSSL 1.0.x, which is still in use on RHEL7 and CentOS7.

Fixes #71037

Author: bartonjs
Assignees: bartonjs
Labels:

area-System.Net.Security
Milestone: 7.0.0

@bartonjs
Copy link
Member Author

bartonjs commented Aug 9, 2022

/azp list

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 9, 2022

CI/CD Pipelines for this repository:

@bartonjs
Copy link
Member Author

bartonjs commented Aug 9, 2022

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 9, 2022

Azure Pipelines successfully started running 1 pipeline(s).

wfurt
wfurt approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member

wfurt commented Aug 9, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 9, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@bartonjs
Copy link
Member Author

bartonjs commented Aug 9, 2022

The test launch failures in outerloop-linux are confusing... seeing if "outerloop" works better, since I don't see anyone having recently run outerloop-linux.

@bartonjs
Copy link
Member Author

bartonjs commented Aug 9, 2022

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 9, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@bartonjs
Copy link
Member Author

bartonjs commented Aug 10, 2022

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@bartonjs
Copy link
Member Author

bartonjs commented Aug 10, 2022

Centos.7 is failing to launch with ./RunTests.sh: line 168: /root/helix/work/correlation/dotnet: No such file or directory

RedHat.7 is failing to launch with ./RunTests.sh: line 168: /mnt/work/A2A208BE/p/dotnet: No such file or directory

These same launch errors are showing on everyone launching outerloop that I can see. It'd be nice to see the test pass in CI before merging, but I guess we'll just see it in the big ring.

@bartonjs bartonjs merged commit 312bd14 into dotnet:main Aug 10, 2022
@bartonjs bartonjs deleted the rhel7_ocsp branch August 10, 2022 16:11
@bartonjs bartonjs added cryptographic-docs-impact needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration labels Aug 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurt wfurt wfurt approved these changes

@rzikm rzikm rzikm approved these changes

Assignees

@bartonjs bartonjs

Labels

area-System.Net.Security needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Test failure System.Net.Security.Tests.CertificateValidationRemoteServer.ConnectWithRevocation_StapledOcsp(offlineContext: False)

3 participants

@bartonjs @wfurt @rzikm