NativeAOT tests interopservices#73200
Merged
AaronRobinsonMSFT merged 12 commits intodotnet:mainfrom Aug 4, 2022
Merged
Conversation
Remove SetWin32ContextInIDispatchAttribute attribute and tests. - this was no longer in the ref assembly so just removing it.
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsContributes to #73145
|
jkotas
reviewed
Aug 2, 2022
...e.InteropServices.UnitTests/System/Runtime/InteropServices/ComAwareEventInfoTests.Windows.cs
Show resolved
Hide resolved
Member
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Thank you for working on this! This helps a lot!
...me.InteropServices.UnitTests/System/Runtime/InteropServices/Marshal/DestroyStructureTests.cs
Outdated
Show resolved
Hide resolved
...Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVisibleAttributeTests.cs
Show resolved
Hide resolved
...InteropServices.UnitTests/System/Runtime/InteropServices/Marshal/GenerateGuidForTypeTests.cs
Outdated
Show resolved
Hide resolved
...vices.UnitTests/System/Runtime/InteropServices/Marshal/GetDelegateForFunctionPointerTests.cs
Outdated
Show resolved
Hide resolved
...me.InteropServices.UnitTests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs
Show resolved
Hide resolved
...stem.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs
Outdated
Show resolved
Hide resolved
...tem.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ProgIdAttributeTests.cs
Show resolved
Hide resolved
This reverts commit 366429d.
expansive testing on all Windows SKUs.
jkotas
reviewed
Aug 4, 2022
...teropServices.UnitTests/System/Runtime/InteropServices/Marshal/Common/CommonTypes.Windows.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 4, 2022
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 4, 2022
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
Outdated
Show resolved
Hide resolved
elinor-fung
approved these changes
Aug 4, 2022
Member
elinor-fung
left a comment
There was a problem hiding this comment.
Yay for the managed COM server and removing the surprise dependency on some AD type.
...opServices.UnitTests/System/Runtime/InteropServices/Marshal/GetComInterfaceForObjectTests.cs
Outdated
Show resolved
Hide resolved
...ntime.InteropServices.UnitTests/System/Runtime/InteropServices/Marshal/GetEndComSlotTests.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #73145
/cc @MichalStrehovsky @jkotas