Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

are the message-ids really unique across all sessions?

are the message-ids really unique across all sessions?

It looks like yes.

is that true for our ids?

That is exactly the case that we are getting the message error described in the issue, we are sending messageID=259, and the session does not exist anymore, so we receive an answer with messageID=259 and another sessionID, that is why we weren't find it.

Where we increment:

Where we use it:

This is only reset on firefox when we connect to the page, on chrome it's never reset.

Session id can be different if there is a redirect, but the message id is kept.

What do you mean by a "redirect" here?

I have no idea how to create a test case for it.

When it was observed? This link to issue does not work, could you check it?

I have no idea how to create a test case for it.

When it was observed? This link to issue does not work, could you check it?

It looks like you don't have rights to see it, I already asked for, let's wait.

Session id can be different if there is a redirect, but the message id is kept.

What do you mean by a "redirect" here?

Something like go to a login page and login.

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

This still doesn't seem correct to me (not to mention we'd need to change the hash computation) based on the error in the linked issue my guess is that we're comparing one message with a string.Empty sessionId to another with a null one. Can you changing the MessageId constructor to do:

        this.sessionId = string.IsNullOrEmpty (sessionId) ? null : sessionId;

This still doesn't seem correct to me (not to mention we'd need to change the hash computation) based on the error in the linked issue my guess is that we're comparing one message with a string.Empty sessionId to another with a null one. Can you changing the MessageId constructor to do:

        this.sessionId = string.IsNullOrEmpty (sessionId) ? null : sessionId;

This is exactly what we are comparing:

see the pending_cmds
SessionId = FD9F77A4C958D595651B0F5D39AC75AC - CommandId = 277
SessionId = 469F7AE3DF255CC5FC81CF5BEF2B7523 - CommandId = 278
SessionId = FD9F77A4C958D595651B0F5D39AC75AC - CommandId = 276
SessionId = FD9F77A4C958D595651B0F5D39AC75AC - CommandId = 275
I was looking for: SessionId =  - CommandId = 276
see the pending_cmds
SessionId = FD9F77A4C958D595651B0F5D39AC75AC - CommandId = 277
SessionId = 469F7AE3DF255CC5FC81CF5BEF2B7523 - CommandId = 278
SessionId = FD9F77A4C958D595651B0F5D39AC75AC - CommandId = 276
SessionId = FD9F77A4C958D595651B0F5D39AC75AC - CommandId = 275
I was looking for: SessionId =  - CommandId = 277

So to be clear, we are sending command 276 from sessionID FD9F77A4C958D595651B0F5D39AC75AC and receiving the answer from SessionId = "";
We are sending command 277 from sessionID FD9F77A4C958D595651B0F5D39AC75AC and also receiving the answer from SessionId = "";

So I agree we need to change the hash, but I don't think that considering an empty string as NULL will fix it.

I don't see how this would fix the dictionary lookup in the general case. We need to make sure the hash code and Equals use the same logic

After testing more and more, I detected that this is not always happening, it only happens sometimes, but I'm confident that the fix works because I added a message in the code like this:

And I ran a lot of times until see the "we would get the error" message.

Also after a lot of tests I got an error when we receive and send the Debugger.Enabled message, same error "Session with given id not found", so I also protected that message.

iirc a missing sessionId means it applies to all sessions so it makes more sense than a different sessionId. The updates look fine although it might make sense to warn if the sessions have a value and are different because I don't think that should ever happen. What command is the response to?

iirc a missing sessionId means it applies to all sessions so it makes more sense than a different sessionId. The updates look fine although it might make sense to warn if the sessions have a value and are different because I don't think that should ever happen. What command is the response to?

{
  "id": 536,
  "method": "Debugger.enable",
  "params": {},
  "sessionId": "EDA0856A52259CB6A25FDCB8A6282422"
}

{
  "id": 537,
  "method": "Runtime.evaluate",
  "params": {
    "expression": "getDotnetRuntime(0).INTERNAL.mono_wasm_runtime_is_ready",
    "objectGroup": "mono-debugger",
    "includeCommandLineAPI": false,
    "silent": false,
    "returnByValue": true
  },
  "sessionId": "EDA0856A52259CB6A25FDCB8A6282422"
}