Skip to content

Fix EncryptDecrypt test#72874

Merged
danmoseley merged 2 commits intodotnet:mainfrom
danmoseley:EncryptDecrypt
Jul 26, 2022
Merged

Fix EncryptDecrypt test#72874
danmoseley merged 2 commits intodotnet:mainfrom
danmoseley:EncryptDecrypt

Conversation

@danmoseley
Copy link
Member

Fix #12339

I can't reproduce this locally, but it seems reasonable to assume it just need a bit more time for the encryption to release its handle on the file; or for Defender or equivalent to do so (the file has just been written)

This will retry every 100ms up to 30 times.

@ghost
Copy link

ghost commented Jul 26, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #12339

I can't reproduce this locally, but it seems reasonable to assume it just need a bit more time for the encryption to release its handle on the file; or for Defender or equivalent to do so (the file has just been written)

This will retry every 100ms up to 30 times.

Author: danmoseley
Assignees: -
Labels:

area-System.IO

Milestone: -

Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, lgtm.

@danmoseley
Copy link
Member Author

@dotnet/dnceng do we already have retries here? cc test monitor of the week @noahfalk

/ runtime (Build Browser wasm Linux Release _Threading_PerfTracing_BuildOnly)
.dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets#L19
.dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Failed to download package 'Microsoft.AspNetCore.App.Ref.6.0.5' from 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.aspnetcore.app.ref/6.0.5/microsoft.aspnetcore.app.ref.6.0.5.nupkg'.
The HTTP request to 'GET https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.aspnetcore.app.ref/6.0.5/microsoft.aspnetcore.app.ref.6.0.5.nupkg' has timed out after 100000ms.
 [Check failure on line 19 in .dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets](https://github.com/dotnet/runtime/pull/72874/files#annotation_4124695891) 

/ runtime (Build Browser wasm Linux Release _Threading_PerfTracing_BuildOnly)
.dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets#L19
.dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Central Directory corrupt.

@MattGal
Copy link
Member

MattGal commented Jul 26, 2022

@dotnet/deenceng do we already have retries here? cc test monitor of the week @noahfalk

/ runtime (Build Browser wasm Linux Release _Threading_PerfTracing_BuildOnly)
.dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets#L19
.dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Failed to download package 'Microsoft.AspNetCore.App.Ref.6.0.5' from 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.aspnetcore.app.ref/6.0.5/microsoft.aspnetcore.app.ref.6.0.5.nupkg'.
The HTTP request to 'GET https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.aspnetcore.app.ref/6.0.5/microsoft.aspnetcore.app.ref.6.0.5.nupkg' has timed out after 100000ms.
 [Check failure on line 19 in .dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets](https://github.com/dotnet/runtime/pull/72874/files#annotation_4124695891) 

/ runtime (Build Browser wasm Linux Release _Threading_PerfTracing_BuildOnly)
.dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets#L19
.dotnet/sdk/7.0.100-preview.5.22307.18/NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Central Directory corrupt.

I'll take a look; local retries can be tricky to find in the logs (Edit this is a build log not a test log)

@MattGal
Copy link
Member

MattGal commented Jul 26, 2022

@danmoseley the retries we added as "experimental" before are built in to NuGet Clients in 7.0, so the retry occurred but it thought it succeeded. What happened here seems to be that the zip file was downloaded incompletely but "successfully", leading to the later on "Central Directory corrupt" message. This is the first I've seen it but if you see a second one it may be worth creating a known issue about.

@danmoseley
Copy link
Member Author

Opened an issue for the failure in the host tests. The WASM/tvOS Nuget feed issues can be ignored as the test doesn't run there anyway.

@danmoseley danmoseley merged commit 0be6c64 into dotnet:main Jul 26, 2022
@danmoseley danmoseley deleted the EncryptDecrypt branch July 26, 2022 22:36
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failed: System.IO.Tests.EncryptDecrypt.EncryptDecrypt_Read

3 participants