[wasm] Move some defaults out of the templates#72626
Merged
lewing merged 12 commits intodotnet:mainfrom Jul 25, 2022
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
radical
approved these changes
Jul 21, 2022
- Running with `node` fails when relinking, or AOT'ing in Debug config - this seems to be when linking is done with `-O0` - it seems to work fine with emsdk `3.1.7` though - For `Debug` config we automatically set `_WasmDevel=true`, which then sets `-O0` - This is not seen on CI, since we don't run non-template tests in `Debug`. But for local runs, we do. - The template tests are explicitly run for Debug, and Release, and they break because of this - So, setting `_WasmDevel=false` for now, till this gets fixed - Also, set `OutputType=Exe` in the project file itself, so it gets set before `Microsoft.NET.Sdk` gets imported, or early enough.
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
I noticed that we now have console proxy in the production code runtime/src/mono/wasm/runtime/debug.ts Line 475 in cbe29e8 perhaps we could add it to |
Member
|
This is ready I believe. |
Member
Author
|
Might be some follow up still but this is an improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes #72436 .