Fix error handling for COM initialization failures during thread startup #72353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
commented
Jul 18, 2022
|
|
||
| _initialApartmentState = state; | ||
| return true; | ||
| retState = _initialApartmentState; |
Member
Author
There was a problem hiding this comment.
(this != CurrentThread) path needs to have the same error handling and throw InvalidOperationException as the (this == CurrentThread) path.
jkotas
commented
Jul 18, 2022
|
|
||
| if (GetThreadStateBit(ThreadState.Unstarted)) | ||
| { | ||
| // Lack of memory is the only expected reason for thread creation failure |
Member
Author
There was a problem hiding this comment.
This was incorrect assumption. COM initialization can fail with PlatformNotSupportedException on Nano server.
tlakollo
approved these changes
Jul 18, 2022
Contributor
tlakollo
left a comment
There was a problem hiding this comment.
I'm not an expert in the area, but functionally looks good and the tests are passing. Thanks for the comments too
| // Lack of memory is the only expected reason for thread creation failure | ||
| throw new ThreadStartException(new OutOfMemoryException()); | ||
| Exception? startException = _startException; | ||
| startException = null; |
Member
There was a problem hiding this comment.
I think this should be _startException = null;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72352