Skip to content

Add/implement ObsoletedInOSPlatformAttribute.#71846

Merged
buyaa-n merged 2 commits intodotnet:mainfrom
rolfbjarne:obsoleted-in-osplatform-attribute-with-tests
Jul 8, 2022
Merged

Add/implement ObsoletedInOSPlatformAttribute.#71846
buyaa-n merged 2 commits intodotnet:mainfrom
rolfbjarne:obsoleted-in-osplatform-attribute-with-tests

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

As described here:

#68557 (comment)

@buyaa-n will implement the changes required in the analyzer (target is RC1).

Fixes #68557.

As described here:

dotnet#68557 (comment)

@buyaa-n will implement the changes required in the analyzer (target is RC1).

Fixes dotnet#68557.
@rolfbjarne rolfbjarne requested a review from buyaa-n July 8, 2022 18:09
@ghost
Copy link
Copy Markdown

ghost commented Jul 8, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned rolfbjarne Jul 8, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jul 8, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@rolfbjarne rolfbjarne marked this pull request as ready for review July 8, 2022 18:14
@ghost
Copy link
Copy Markdown

ghost commented Jul 8, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

As described here:

#68557 (comment)

@buyaa-n will implement the changes required in the analyzer (target is RC1).

Fixes #68557.

Author: rolfbjarne
Assignees: rolfbjarne
Labels:

area-Meta, new-api-needs-documentation

Milestone: -

Copy link
Copy Markdown
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@buyaa-n buyaa-n merged commit 4dd047a into dotnet:main Jul 8, 2022
@rolfbjarne rolfbjarne deleted the obsoleted-in-osplatform-attribute-with-tests branch July 11, 2022 07:57
@ghost ghost locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add back ObsoletedInOSPlatformAttribute for .NET 7

3 participants