Make MetadataReader.GetAssemblyName(string assemblyFile) public#71801
Merged
buyaa-n merged 4 commits intodotnet:mainfrom Jul 11, 2022
Merged
Make MetadataReader.GetAssemblyName(string assemblyFile) public#71801buyaa-n merged 4 commits intodotnet:mainfrom
buyaa-n merged 4 commits intodotnet:mainfrom
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata |
buyaa-n
commented
Jul 8, 2022
src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 8, 2022
src/libraries/System.Reflection.Metadata/ref/System.Reflection.Metadata.cs
Outdated
Show resolved
Hide resolved
….Metadata.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
joperezr
approved these changes
Jul 8, 2022
Member
joperezr
left a comment
There was a problem hiding this comment.
LGTM other than Jan's comment.
jkotas
approved these changes
Jul 11, 2022
Contributor
Author
|
The test failure is know issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update internal API: MetadataReader.GetAssemblyName(string assemblyFile) to public
Fixes #63960
Related to #63915