Skip to content

Use UnrelatedR2RCode flag when --compilebubblegenerics is specified#71798

Merged
davidwrighton merged 2 commits intodotnet:mainfrom
davidwrighton:fix_46160
Aug 1, 2022
Merged

Use UnrelatedR2RCode flag when --compilebubblegenerics is specified#71798
davidwrighton merged 2 commits intodotnet:mainfrom
davidwrighton:fix_46160

Conversation

@davidwrighton
Copy link
Member

Fixes #46160

@ghost ghost assigned davidwrighton Jul 8, 2022
@davidwrighton davidwrighton requested a review from trylek July 8, 2022 00:42
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@davidwrighton davidwrighton merged commit 8510ed6 into dotnet:main Aug 1, 2022
@alpencolt
Copy link

@davidwrighton as I understand this PR allows to include copies of compiled generics from third ni files to current for cases like in #46160, am I right?
Have you measured file size increase?

@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2022
@davidwrighton davidwrighton deleted the fix_46160 branch April 13, 2023 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version Bubble implementation flaw: some methods are forced to rejit

3 participants