Release global lock before throwing exceptions from the Unix WaitSystem #71626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception throwing and handling can enter wait system recursively that will lead to deadlock. Fixes dotnet#70010
Member
Author
|
cc @dotnet/ilc-contrib |
VSadov
reviewed
Jul 5, 2022
| } | ||
| finally | ||
| { | ||
| lockHolder.Dispose(); |
Member
There was a problem hiding this comment.
Should this be after clearing waitableObjects?
Member
Author
There was a problem hiding this comment.
waitableObjects is thread local pooled array. It should be safe to clean it outside the lock.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception throwing and handling can enter wait system recursively that will lead to deadlock.
Fixes #70010