Skip to content

Throw protocol error returned by GoAway on HTTP/2 connection negotation #71572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JamesNK merged 7 commits into from
Jul 5, 2022
Merged

Throw protocol error returned by GoAway on HTTP/2 connection negotation #71572

JamesNK merged 7 commits into from
Jul 5, 2022

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 2, 2022

Fixes #63715

@ghost
Copy link

ghost commented Jul 2, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #63715

Author: JamesNK
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@ghost ghost assigned JamesNK Jul 2, 2022
@JamesNK JamesNK changed the title Throw protocol error returned by goaway on HTTP/2 connection negotation Throw protocol error returned by Goaway on HTTP/2 connection negotation Jul 2, 2022
@JamesNK JamesNK changed the title Throw protocol error returned by Goaway on HTTP/2 connection negotation Throw protocol error returned by GoAway on HTTP/2 connection negotation Jul 2, 2022
antonfirsov
antonfirsov approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesNK JamesNK merged commit a248f40 into dotnet:main Jul 5, 2022
@JamesNK JamesNK deleted the jamesnk/sendasync-protocolerror branch July 5, 2022 00:13
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@antonfirsov antonfirsov antonfirsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JamesNK JamesNK

Labels

area-System.Net.Http

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

SocketsHttpHandler: GOAWAY on connection handshake

3 participants

@JamesNK @antonfirsov @karelz