Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThe canonical form of a Fixes #64375.
|
e6c4bc1 to
9396394
Compare
Contributor
Author
|
@dotnet/jit-contrib |
In the frontend, for better or worse, the canonical form of address arithmetic is explicit pointer arithmetic.
9396394 to
c0cfc6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canonical form of a
LEA-equivalent expression in HIR is explicit address arithmetic.Fixes #64375.
Diffs - some improvements from
LCL_FLDfolding, some regressions from inserting the zero-extending casts. Also a small TP regression, payed for with #69958.