Support ref fields in System.Reflection.Metadata.Ecma335.BlobEncoder.
#69378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#68309. A test case was added.
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata Issue DetailsFixes #68309.
|
Member
|
/cc @cston |
Member
|
The ref assembly must also be updated. |
cston
reviewed
May 16, 2022
src/libraries/System.Reflection.Metadata/tests/Metadata/Ecma335/Encoding/BlobEncodersTests.cs
Show resolved
Hide resolved
Contributor
Author
|
Feedback was addressed. |
Member
|
This PR is in a weird state due to the Azure issues over the weekend. @teo-tsirpanis Can you push up a minor change just to re-trigger AzDO? |
Member
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@AaronRobinsonMSFT I closed and reopened the PR, the CI got triggered and it is now green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68309.
A test case was added.