Fix typo in AssemblyName handling #69157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in AssemblyName handling and add test that catches the bug introduced by the typo
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsFix typo in AssemblyName handling and add test that catches the bug introduced by the typo
|
jkoritzinsky
approved these changes
May 10, 2022
danmoseley
reviewed
May 10, 2022
| Assembly a = Assembly.Load(an); | ||
|
|
||
| byte[] publicKey = a.GetName().GetPublicKey(); | ||
| Assert.True(publicKey.Length > 0); |
Member
There was a problem hiding this comment.
do the public key and PKT have defined lengths (eg., 8 and 160) and if so, could we assert the lengths of each here?
Member
Author
There was a problem hiding this comment.
Yes, they do. We have AssemblyName tests that verify that.
This test only requires that the public key and public key token are non-empty to cover the desired scenario.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in AssemblyName handling and add test that catches the bug introduced by the typo