Skip to content

Normalize S.S.Cryptography's ref.cs file #68993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danmoseley merged 1 commit into from
May 7, 2022
Merged

Normalize S.S.Cryptography's ref.cs file #68993

danmoseley merged 1 commit into from
May 7, 2022

Conversation

@bartonjs
Copy link
Member

@bartonjs bartonjs commented May 6, 2022 •
edited
Loading

The generated order of some EditorBrowsables and Obsoletes seems to have flipped,
and the whitespace in ObsoleteAttribute DIagnosticId/UriFormat setters seems to have changed.

The removed override methods were all removed in #66349, and are
all from sealed types, so the removal doesn't matter.

@bartonjs
Normalize S.S.Cryptography's ref.cs file
aa60ecc 
The order of some EditorBrowsables and Obsoletes seems to have flipped,
and the whitespace in ObsoleteAttribute DIagnosticId/UriFormat setters.
@bartonjs bartonjs added this to the 7.0.0 milestone May 6, 2022
@bartonjs bartonjs self-assigned this May 6, 2022
@ghost
Copy link

ghost commented May 6, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 6, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

The generated order of some EditorBrowsables and Obsoletes seems to have flipped,
and the whitespace in ObsoleteAttribute DIagnosticId/UriFormat setters seems to have changed.

The removed overridden methods were all removed in #66349, and are
all from sealed types, so the removal doesn't matter.

Author: bartonjs
Assignees: bartonjs
Labels:

area-System.Security
Milestone: 7.0.0

@danmoseley
Copy link
Member

danmoseley commented May 7, 2022

Failures are #60933

@danmoseley danmoseley merged commit 885d207 into dotnet:main May 7, 2022
@runfoapp runfoapp bot mentioned this pull request May 9, 2022
Closed
@bartonjs bartonjs deleted the update_crypto_ref branch May 9, 2022 15:32
@ghost ghost locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vcsjones vcsjones vcsjones approved these changes

Assignees

@bartonjs bartonjs

Labels

area-System.Security

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bartonjs @danmoseley @vcsjones