Skip to content

Fix for FileStream.Lock(Int64, Int64) always fails on FreeBSD #65831 #68908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsitnik merged 1 commit into from
May 5, 2022
Merged

Fix for FileStream.Lock(Int64, Int64) always fails on FreeBSD #65831 #68908

adamsitnik merged 1 commit into from
May 5, 2022

Conversation

@Tarun047
Copy link
Contributor

@Tarun047 Tarun047 commented May 5, 2022 •
edited
Loading

This PR aims to fix the Issue #65831.

  • Updated the checks in FileStream.Lock() and FileStream.Unlock() to consider if Operating System is FreeBSD
  • Updated the tests using FIleStream.Lock() and FileStream.Unlock() to adjust to the change
  • Updated Reference Assembly to match FileStream.Lock() and FileStream.Unlock() signatures to have the extra added attributes.

@ghost ghost added area-System.IO new-api-needs-documentation community-contribution Indicates that the PR has been added by a community member labels May 5, 2022
@ghost
Copy link

ghost commented May 5, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 5, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR aims to fix the Issue #65831.
-[x] Updated the checks in FileStream.Lock() and FileStream.Unlock() to consider if Operating System is FreeBSD
-[x] Updated the tests using FIleStream.Lock() and FileStream.Unlock() to adjust to the change
-[x] Updated Reference Assembly to match FileStream.Lock() and FileStream.Unlock() signatures to have the extra added attributes.

Author: Tarun047
Assignees: -
Labels:

area-System.IO, new-api-needs-documentation, community-contribution
Milestone: -

@adamsitnik adamsitnik self-assigned this May 5, 2022
@adamsitnik adamsitnik added this to the 7.0.0 milestone May 5, 2022
adamsitnik
adamsitnik approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Tarun047 !

@adamsitnik adamsitnik merged commit b84a057 into dotnet:main May 5, 2022
@jozkee jozkee mentioned this pull request May 5, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees

@adamsitnik adamsitnik

Labels

area-System.IO community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Tarun047 @adamsitnik