Fix slow JSON assert #68027
Fix slow JSON assert #68027
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFix #67878 The string being constructed by this assert substantially slows down the JSON tests, so much that on slow machines they time out.
|
|
Committing without validation as it's a small change and this is taking out PR validation. |
|
Is the slow down only happening on pre-.NET 6 builds? That string should never be evaluated on .NET 6+ unless the assert fails. |
|
Right, I was working against main, but the slowdown was when the tests ran on .NET Framework which is consistent with your observation. |
|
In case anyone ever wonders why the new interpolated string handler overloads we added to Debug.Assert are useful ;-) |
Fix #67878
The string being constructed by this assert substantially slows down the JSON tests, so much that on slow machines they time out.
Before (on my machine) System.Text.Json tests -- 34sec .NET 7 tests/208sec .NET Framework tests. Helix only allows 2700 seconds; I guess 32 bit Arm machines are about 10x slower than mine.
After 39/107