Allow running System.Reflection tests on NativeAOT #67575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baselines/annotates anything that needs baselining/annotating.
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsBaselines/annotates anything that needs baselining/annotating.
|
2 tasks
jkotas
reviewed
Apr 19, 2022
|
|
||
| Assembly a = typeof(AssemblyNameTests).Assembly; | ||
| Assert.Equal(new AssemblyName(a.FullName).ToString(), AssemblyName.GetAssemblyName(AssemblyPathHelper.GetAssemblyLocation(a)).ToString()); | ||
| if (!PlatformDetection.IsNativeAot) |
Member
There was a problem hiding this comment.
This is generally incompatible with single-file. Would it be better to skip the test when AssemblyPathHelper.GetAssemblyLocation returns empty path?
LakshanF
approved these changes
May 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baselines/annotates anything that needs baselining/annotating.