Don't mark prefldinit4 as requiring process isolation#65596
Merged
trylek merged 1 commit intodotnet:mainfrom Feb 19, 2022
Merged
Don't mark prefldinit4 as requiring process isolation#65596trylek merged 1 commit intodotnet:mainfrom
trylek merged 1 commit intodotnet:mainfrom
Conversation
Turns out this particular test doesn't actually need process isolation, I overzealously marked it as such in a previous wave just because it's a static initialization test. This lets us postpone dealing with out-of-process ilproj tests to a later phase. Thanks Tomas
|
Tagging subscribers to this area: @hoyosjs Issue DetailsTurns out this particular test doesn't actually need process Thanks Tomas /cc @dotnet/jit-contrib
|
jkoritzinsky
approved these changes
Feb 18, 2022
BruceForstall
approved these changes
Feb 18, 2022
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out this particular test doesn't actually need process
isolation, I overzealously marked it as such in a previous wave
just because it's a static initialization test. This lets us
postpone dealing with out-of-process ilproj tests to a later
phase.
Thanks
Tomas
/cc @dotnet/jit-contrib