Skip to content

Add attributes for required members#64287

Merged
stephentoub merged 4 commits intodotnet:mainfrom
333fred:required-members-attributes
Jan 27, 2022
Merged

Add attributes for required members#64287
stephentoub merged 4 commits intodotnet:mainfrom
333fred:required-members-attributes

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Jan 25, 2022

Closes #64248.

Relates to test plan dotnet/roslyn#57046

@ghost
Copy link

ghost commented Jan 25, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jan 25, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #64248.

Author: 333fred
Assignees: 333fred
Labels:

area-System.Runtime.CompilerServices

Milestone: -

@stephentoub
Copy link
Member

This also needs:

Also the ifdef for corelib is only necessary if we expect these files to be included into other assemblies beyond corelib.

@333fred
Copy link
Member Author

333fred commented Jan 25, 2022

Also the ifdef for corelib is only necessary if we expect these files to be included into other assemblies beyond corelib.

I somewhat expect that this attribute will be copied by customers, so I'd prefer to keep them.

@333fred 333fred force-pushed the required-members-attributes branch from 6dff2f2 to 94f6258 Compare January 25, 2022 21:45
@333fred 333fred requested a review from stephentoub January 26, 2022 01:45
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@stephentoub stephentoub merged commit 6233735 into dotnet:main Jan 27, 2022
@333fred 333fred deleted the required-members-attributes branch January 27, 2022 19:35
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal]: RequiredMemberAttribute and NoRequiredMembersAttribute

2 participants