Add attributes for required members#64287
Merged
stephentoub merged 4 commits intodotnet:mainfrom Jan 27, 2022
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices Issue DetailsCloses #64248.
|
Member
|
This also needs:
Also the ifdef for corelib is only necessary if we expect these files to be included into other assemblies beyond corelib. |
stephentoub
reviewed
Jan 25, 2022
...s/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/SetsRequiredMembersAttribute.cs
Outdated
Show resolved
Hide resolved
Member
Author
I somewhat expect that this attribute will be copied by customers, so I'd prefer to keep them. |
6dff2f2 to
94f6258
Compare
333fred
commented
Jan 26, 2022
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Outdated
Show resolved
Hide resolved
…b.Shared.projitems
stephentoub
approved these changes
Jan 26, 2022
src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/AttributesTests.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64248.
Relates to test plan dotnet/roslyn#57046