[wasm][tests] Fix, and simplify sample building on CI#63429
[wasm][tests] Fix, and simplify sample building on CI#63429radical merged 7 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines failed to run 1 pipeline(s). |
…)" This reverts commit 5993a3a.
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| creator: dotnet-bot | ||
| testRunNamePrefixSuffix: Mono_$(_BuildConfig) | ||
| scenarios: | ||
| - normal |
There was a problem hiding this comment.
Comment on the section said NodeJs, should we fix it ?
There was a problem hiding this comment.
I have a follow up PR, I'll remove the comment in that.
| eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), | ||
| eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true), | ||
| eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), | ||
| eq(variables['isManualOrIsNotPR'], true), |
There was a problem hiding this comment.
The same conditions you removed are duplicated in many other places of this file. Should we remove them too ?
There was a problem hiding this comment.
@steveisok would you prefer that? Or should I restore the conditions, and just add the manual one?
pavelsavara
left a comment
There was a problem hiding this comment.
LGTM, my comments are more questions than feedback.
|
Failures are unrelated. |
sendtohelixhelp.proj, generate a run script, which allows moving the execution commands to the respective projects.runtime-manual. This was recently changed to run only for nodejs