JIT: refactor fields of GenTreeCall#63402
Conversation
Move `gtStubCallStubAddr` out of the union it shares with class probe, inline, and guarded devirt information, so that we no longer need to save and restore the stub address when we want to probe, guardedly devirtualize, or inline calls. Delete all the code that did saving and restoring, and the field in the inline info struct that held the saved copy. Reorder the fields of the call node so that a bit we're less likely to have internal padding.
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsMove Delete all the code that did saving and restoring, and the field in the Reorder the fields of the call node so that a bit we're less likely to
|
|
cc @dotnet/jit-contrib This is in anticipation of adding yet another kind of info to the mix.... No spmi diffs seen locally. |
EgorBo
left a comment
There was a problem hiding this comment.
LGTM, SuppressProbesFunctor really felt a bit weird 🙂
|
This adds 16 more bytes to Notably it will have to add at least 8 bytes on 64 bit in any case ( Edit: for reference, adding one pointer field to |
Thanks. Reverted that bit. |
Move
gtStubCallStubAddrout of the union it shares with class probe,inline, and guarded devirt information, so that we no longer need to
save and restore the stub address when we want to probe, guardedly
devirtualize, or inline calls.
Delete all the code that did saving and restoring, and the field in the
inline info struct that held the saved copy.
Reorder the fields of the call node so that a bit we're less likely to
have internal padding.