Handle race condition when HttpListener is stopped or closed#63394
Merged
wfurt merged 4 commits intodotnet:mainfrom Jan 5, 2022
Merged
Handle race condition when HttpListener is stopped or closed#63394wfurt merged 4 commits intodotnet:mainfrom
wfurt merged 4 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #63345 If the HttpListener is stopped or closed while
|
MihaZupan
approved these changes
Jan 5, 2022
Member
MihaZupan
left a comment
There was a problem hiding this comment.
The change seems reasonable to me.
I would expect BeginGetContext to have the same issue:
Can you please add the null check there as well?
Contributor
Author
|
Good catch, done in a48c5d9 |
MihaZupan
reviewed
Jan 5, 2022
src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListener.Windows.cs
Outdated
Show resolved
Hide resolved
karelz
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63345
If the HttpListener is stopped or closed while
GetContextis executing, the_currentSessionfield may be null. This PR detects this case and throws aHttpListenerExceptioninstead of aNullReferenceException.