Fix MethodDesc::CbStackPop for string ctors on x86#63391
Merged
jkotas merged 1 commit intodotnet:mainfrom Jan 5, 2022
Merged
Conversation
This method was not taking into account the fact that string ctors don't have dummy this argument after a recent change. Stack walking in cases where prestub for the ctor was invoked resulted in a wrong unwinding of ESP for ctors with more than one argument. This change fixes it by removing "has this" flag from the signature before getting the stack arguments size.
AaronRobinsonMSFT
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was not taking into account the fact that string ctors
don't have dummy this argument after a recent change. Stack walking
in cases where prestub for the ctor was invoked resulted in a wrong
unwinding of ESP for ctors with more than one argument.
This change fixes it by removing "has this" flag from the signature
before getting the stack arguments size.
Close #63003