Remove dead code in OdbcCommandBuilder.UnquoteIdentifier#63363
Merged
stephentoub merged 1 commit intodotnet:mainfrom Jan 5, 2022
Merged
Remove dead code in OdbcCommandBuilder.UnquoteIdentifier#63363stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
Exact same pattern was previously changed in OleDbCommandBuilder.
|
Tagging subscribers to this area: @roji, @ajcvickers Issue DetailsExact same pattern was previously changed in OleDbCommandBuilder.
|
roji
approved these changes
Jan 5, 2022
Member
roji
left a comment
There was a problem hiding this comment.
@stephentoub I'm guessing the original condition was supposed to be && instead of ||, so as to not unquote if quotePrefix is " "... Doesn't really matter at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact same pattern was previously changed in OleDbCommandBuilder.