Enable IDE0059 analyzer: Unnecessary assignment of a value#63340
Merged
marek-safar merged 8 commits intodotnet:mainfrom Jan 12, 2022
Merged
Enable IDE0059 analyzer: Unnecessary assignment of a value#63340marek-safar merged 8 commits intodotnet:mainfrom
marek-safar merged 8 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsnull
|
stephentoub
reviewed
Jan 4, 2022
...n/Runtime/Assemblies/NativeFormat/NativeFormatRuntimeAssembly.GetTypeCore.CaseInsensitive.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
...Reflection.Core/src/System/Reflection/Runtime/CustomAttributes/RuntimeCustomAttributeData.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
...ate.Reflection.Core/src/System/Reflection/Runtime/MethodInfos/RuntimePlainConstructorInfo.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/coreclr/nativeaot/System.Private.TypeLoader/src/Internal/Runtime/TypeLoader/TypeBuilder.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
...Private.TypeLoader/src/Internal/Runtime/TypeLoader/TypeLoaderEnvironment.SignatureParsing.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
...Private.TypeLoader/src/Internal/Runtime/TypeLoader/TypeLoaderEnvironment.SignatureParsing.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/coreclr/tools/Common/Internal/Metadata/NativeFormat/Generator/ReaderGen.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/Microsoft.Extensions.Caching.Memory/src/MemoryCache.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Data.Common/src/System/Data/ConstraintCollection.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Data.Common/src/System/Data/DataColumnCollection.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Data.Common/src/System/Data/DataRelationCollection.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Data.Common/src/System/Data/ForeignKeyConstraint.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
stephentoub
reviewed
Jan 4, 2022
...em.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/common/BerConverter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Net.Http/src/System/Net/Http/Headers/EntityTagHeaderValue.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
...Private.DataContractSerialization/src/System/Runtime/Serialization/CollectionDataContract.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
...stem.Private.DataContractSerialization/src/System/Runtime/Serialization/HybridObjectCache.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlBaseWriter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2022
src/libraries/System.Private.Xml/src/System/Xml/Dom/XmlNodeReader.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 6, 2022
src/libraries/System.Private.Xml/src/System/Xml/Xsl/IlGen/XmlILOptimizerVisitor.cs
Outdated
Show resolved
Hide resolved
671f1dc to
e994c23
Compare
stephentoub
reviewed
Jan 11, 2022
...Private.TypeLoader/src/Internal/Runtime/TypeLoader/TypeLoaderEnvironment.SignatureParsing.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 11, 2022
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 11, 2022
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionFactory.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 11, 2022
...em.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/common/BerConverter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 11, 2022
| // 'receivedBy' can either be a host or a token. Since a token is a valid host, we only verify if the value | ||
| // is a valid host.; | ||
| if (HttpRuleParser.GetHostLength(receivedBy, 0, true, out string? host) != receivedBy.Length) | ||
| if (HttpRuleParser.GetHostLength(receivedBy, 0, true, out _) != receivedBy.Length) |
Member
There was a problem hiding this comment.
@geoffkizer, not sure how much it actually matters, but looking at the call sites to GetHostLength, it seems several of them end up ignoring the out string host even though the method will end up allocating one, regardless. Might be worth a look, and if there are other similar cases that could be improved.
Contributor
There was a problem hiding this comment.
Yeah, this is ugly. The usual pattern of the GetXLength methods here and elsewhere is that they return an int to indicate the length, but don't actually construct the substring, which the caller can do trivially. Not sure why this one is different. I'll take a look.
Contributor
stephentoub
reviewed
Jan 11, 2022
| { | ||
| static NetworkChange() | ||
| { | ||
| // fake usage of static readonly fields to avoid getting CA1823 warning when we are compiling this partial. |
Contributor
Author
There was a problem hiding this comment.
It was but I changed csproj file not to pull these private fields at all
stephentoub
approved these changes
Jan 11, 2022
Contributor
Author
|
Failures are unrelated due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.