Remove dependency of type system tests on ILCompiler.ReadyToRun#63323
Merged
MichalStrehovsky merged 2 commits intodotnet:mainfrom Jan 5, 2022
Merged
Remove dependency of type system tests on ILCompiler.ReadyToRun#63323MichalStrehovsky merged 2 commits intodotnet:mainfrom
MichalStrehovsky merged 2 commits intodotnet:mainfrom
Conversation
This is now shared unit test project that is not AOT/JIT specific. The recently added MarshalUtilsTests.cs created a dependency on these.
jkotas
reviewed
Jan 5, 2022
| <Platforms>AnyCPU;x64</Platforms> | ||
| <PlatformTarget>AnyCPU</PlatformTarget> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <DefineConstants>READYTORUN;$(DefineConstants)</DefineConstants> |
Member
There was a problem hiding this comment.
We should not have any PInvoke stubs that do any actual marshaling in CoreLib anymore. It should be possible to clean up these ifdefs by stripping the bit of marshaling generation from crossgen2 that it still has (ie only generate stubs that do not require any actual marshaling in crossgen2).
It does not have to be done in this PR, but it may be nice to add comment.
Member
Author
There was a problem hiding this comment.
I've added READYTORUN as a shortcut because without it I would need to include InteropStateManager.cs and that depends on a bunch of more files. It was convenient.
I'll put it in a comment.
jkotas
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is now shared unit test project that is not AOT/JIT specific.
The recently added MarshalUtilsTests.cs created a dependency on these.